Skip to content

[5.9] Add request argument to opt-out of source file path information #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2023
Merged

[5.9] Add request argument to opt-out of source file path information #528

merged 1 commit into from
Mar 31, 2023

Conversation

d-ronnqvist
Copy link
Contributor

Cherry-pick of #526

  • Explanation: Add an argument to the ConvertService request to allow for opting out of source file path information in the response
  • Scope: ConvertService
  • Radar: rdar://107075861
  • Risk: Low.
  • Testing: New tests verify that the source file path information is omitted when the new request argument it passed
  • Reviewer: @ethan-kusters

@d-ronnqvist d-ronnqvist requested a review from franklinsch March 31, 2023 15:02
@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist requested a review from sara-radi March 31, 2023 16:53
@d-ronnqvist d-ronnqvist merged commit 06737e0 into swiftlang:release/5.9 Mar 31, 2023
@d-ronnqvist d-ronnqvist deleted the convert-service-skip-source-repository-5.9 branch March 31, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sara-radi sara-radi sara-radi approved these changes

@franklinsch franklinsch Awaiting requested review from franklinsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-ronnqvist @sara-radi