[6.2] Fix false positive curation for article links with extra path components #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
d-ronnqvist
commented
Jun 26, 2025
d-ronnqvist
commented
- Explanation: This fixes a false positive curation for article links with extra path components
- Scope: Unexpected curation for links that DocC doesn't resolve.
- Issue: rdar://150874238
- Risk: Low.
- Testing: Added tests that this type of unresolved article links doesn't result in curation. Manually verified with the project where this issue was originally reported. Existing automated tests pass.
- Reviewer: @patshaughnessy
- Original PR: Fix false positive curation for article links with extra path components #1235
…nts (swiftlang#1235) * Fix false positive curation for article links with extra path components rdar://150874238 * Remove explicit `.init` in test file * Remove unused variable in test * Add missing path separator in curator fallback code path
|
@swift-ci please test |
franklinsch
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.