Skip to content

Allow hiding available tags in NavigatorCard.vue #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dobromir-hristov
Copy link
Contributor

Bug/issue #, if applicable: 100278813

Summary

Allows hiding any available tags in the NavigatorCard search

Dependencies

NA

Testing

To test this you would need to extend the NavigatorCard and apply the hideAvailableTags: true prop.

Assert no tags are shown, no matter what navigator items you have.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

@dobromir-hristov dobromir-hristov marked this pull request as ready for review February 27, 2023 07:20
@dobromir-hristov
Copy link
Contributor Author

@swift-ci test

Copy link
Contributor

@mportiz08 mportiz08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing but should be easy to fix. The implementation looks good.

@dobromir-hristov
Copy link
Contributor Author

@swift-ci test

@mportiz08
Copy link
Contributor

@swift-ci test

@mportiz08 mportiz08 merged commit f7e8dd1 into swiftlang:main Feb 28, 2023
@mportiz08 mportiz08 deleted the dhristov/r100278813-allow-hiding-available-tags branch February 28, 2023 21:59
marinaaisa pushed a commit to marinaaisa/swift-docc-render that referenced this pull request Mar 2, 2023
mportiz08 pushed a commit that referenced this pull request Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants