Skip to content

[Linux] Enable build IDs. #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Linux] Enable build IDs. #496

merged 1 commit into from
Jul 23, 2024

Conversation

al45tair
Copy link
Contributor

We should use build IDs on Linux so that we can identify the built artefacts, and also so that we can match them up with debug information should we choose to separate it.

rdar://130582882

@al45tair al45tair requested a review from grynspan June 26, 2024 13:00
@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

@swift-ci Please test Windows platform

@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

@swift-ci Please test Windows platform

@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

@swift-ci Please test Windows platform

@al45tair
[Linux] Enable build IDs.
9512507 
We should use build IDs on Linux so that we can identify the built
artefacts, and also so that we can match them up with debug
information should we choose to separate it.

rdar://130582882
@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

@swift-ci Please test Windows platform

@al45tair
Copy link
Contributor Author

al45tair commented Jul 1, 2024 •
edited
Loading

The macOS failure suggests that there's some configuration issue with the XCTest tests:

dyld[22635]: Symbol not found: _swift_getTypeByMangledNameInContext2
  Referenced from: <825F68B9-36A3-3A4C-842D-8F987CF7BB6E> /Users/ec2-user/jenkins/workspace/swift-corelibs-xctest-PR-macos/branch-main/swift-corelibs-xctest/Tests/Functional/TestCaseLifecycle/Misuse/Output/TestCaseLifecycleMisuse (built for macOS 14.2 which is newer than running OS)
  Expected in:     <087DADAD-D590-35EA-AC4D-7B0E966804EB> /usr/lib/swift/libswiftCore.dylib

(The "built for macOS 14.2 which is newer than running OS" part suggests that maybe the wrong deployment target is being used here.)

// @briancroom @stmontgomery

@al45tair
Copy link
Contributor Author

al45tair commented Jul 1, 2024

The Windows failure seems to be a failure to fetch the sources from git.

@al45tair
Copy link
Contributor Author

al45tair commented Jul 1, 2024

@swift-ci Please test Windows platform

@grynspan
Copy link
Contributor

grynspan commented Jul 2, 2024

I don't think we generally expect corelibs-xctest to work on macOS. In the past, we've discussed removing the macOS job from CI.

@al45tair
Copy link
Contributor Author

al45tair commented Jul 4, 2024

I don't think we generally expect corelibs-xctest to work on macOS. In the past, we've discussed removing the macOS job from CI.

I guess I can't merge this in that case, because the macOS platform test is marked as "Required". // @briancroom @grynspan

@al45tair al45tair merged commit 7a9df99 into swiftlang:main Jul 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom briancroom approved these changes

@grynspan grynspan Awaiting requested review from grynspan

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff

Assignees

@al45tair al45tair

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@al45tair @grynspan @stmontgomery @briancroom