-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add brotli support to FoundationNetworking #5251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
swiftlang/swift#83441 |
Seems build failed. I see that brotli is not checked out. Do I need a 'clean' test? According to https://github.com/swiftlang/swift/blob/main/docs/ContinuousIntegration.md, this is a thing, but unsure from reading it whether that will make a difference. |
swiftlang/swift#83441 |
the related pull request is at swiftlang/swift#83441 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows builds the toolchain without SPM and without the dependency automation in WindowsSwiftPMDependencies.cmake. We need this to be wired up into the CMake build properly.
What extra pieces would need to be wired up in this build here? I know it's expected that the Windows toolchain build wouldn't use |
My reading (and discussion with Jeremy) is that The meaty piece in this PR is just the 2 test cases in my opinion. |
Ah, so Foundation itself won't need to link to brotli because curl will automatically ensure that the paths are exported and passed along to the linker? |
Add brotli as a dependency to enable brotli decoding for curl.
On Windows, only brotlicommon.lib and brotlidec.lib is linked.
brotlienc.lib is intentionally left out as curl does not need it. brotlienc.lib is also much larger in size (~3.8MB).