[lldb] Add test to check that we can resolve self even if there are no references to it in a dynamic context #2156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vedantk
approved these changes
Nov 19, 2020
|
We'll need to merge this into the |
|
@swift-ci test |
|
Looks like the runtime reporting for exclusivity violations has changed. lldb will need to be fixed before we can merge. |
…ences to it in a dynamic context
augusto2112
force-pushed
the
test-protocol-default-extension-no-self-reference
branch
from
85418f3 to
bf1d456
Compare
|
Hi Vedant, do you think this is mergeable now? I'm having some weird issues with my system, and I can't build swift atm, so I wasn't able to test locally. |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on swiftlang/swift#34835.
@adrian-prantl @vedantk