Replace hand-written make rules with generic ones #1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
JDevlieghere
approved these changes
Jun 13, 2020
fredriss
reviewed
Jun 13, 2020
Comment on lines
+828
to
+829
| $(SWIFTC) $(patsubst -g,,$(SWIFTFLAGS)) -toolchain-stdlib-rpath \ | ||
| -emit-library $(DYLIB_SWIFT_FLAGS) -o $@ \ |
There was a problem hiding this comment.
Why do we need this option? We should run all our tests with the right DYLD_LIBRARY_PATH already
There was a problem hiding this comment.
I wasn't aware of that we did that. This seems to be better to me though, since it allows manually running and debugging the test binaries, (not just through dotest) which is something I often do.
Slightly more concerning though: I had to add this option in order to get the test in rdar://64169273 to work. That might be worth investigating.
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Jul 3, 2020
…builds. This was blocked by an LLDB problem, which is now fixed (swiftlang/llvm-project#1333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/64169273