[BoundsSafety] Fix flexible-array-member-shared-decls-O2.c tests (NFC) #10864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests started failing after 20e8de9. This removes redundant checks (in the tests) that ensure that the available count from flex base pointer is at least the assigned count. In the tests, the flex base pointer is of type `__sized_by(sizeof(struct Outer) + sizeof(int) * len)`, while the assigned count is `len`, which makes the check basically `len >= len`. rdar://153685860
patrykstefanski
requested review from
delcypher,
hnrklssn,
rapidsna,
fpetrogalli,
fahadnayyar and
apple-fcloutier
patrykstefanski
added
the
clang:bounds-safety
|
@swift-ci test llvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests started failing after
20e8de9.
This removes redundant checks (in the tests) that ensure that the available count from flex base pointer is at least the assigned count. In the tests, the flex base pointer is of type
__sized_by(sizeof(struct Outer) + sizeof(int) * len), while the assigned count islen, which makes the check basicallylen >= len.rdar://153685860