Add size for indexstoredb_symbol_role_t #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
bnbarham
force-pushed
the
add-symbol-role-size
branch
3 times, most recently
from
c75d9c5 to
45affac
Compare
|
@swift-ci please test |
benlangmuir
reviewed
Aug 13, 2024
This was previously miscompiling with clang (would be 32 bit instead of 64 bit) and now errors with clang 19. Note that this doesn't seem to have had any impact within indexstore-db itself - the C++ side is using a different enum (`SymbolRole`) which has: ``` Canonical = uint64_t(1) << 63, ``` And seems like the only real use of `Canonical` is `foreachCanonicalSymbolOccurrenceImpl` itself (also C++).
bnbarham
force-pushed
the
add-symbol-role-size
branch
from
45affac to
a72ac5a
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
ahoppen
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously miscompiling with clang (would be 32 bit instead of
64 bit) and now errors with clang 19. Note that this doesn't seem to
have had any impact within indexstore-db itself - the C++ side is
using a different enum (
SymbolRole) which has:And seems like the only real use of
CanonicalisforeachCanonicalSymbolOccurrenceImplitself (also C++).