fix(es/minifier): Don't optimize Number properties when Number is shadowed #10947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mertcanaltin
force-pushed
the
mert/fix/shadowed-number-inlining
branch
from
42905a2 to
520c8d3
Compare
CodSpeed Performance ReportMerging #10947 will not alter performanceComparing Summary
|
mertcanaltin
force-pushed
the
mert/fix/shadowed-number-inlining
branch
from
3fcb34e to
8ffeb76
Compare
Austaras
reviewed
Jul 26, 2025
| return; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Normally we just compare the ident's ctxt with expr_ctx.unresolved_ctxt
There was a problem hiding this comment.
thanks, I edited
kdy1
approved these changes
Jul 26, 2025
lukesandberg
pushed a commit
to lukesandberg/swc
that referenced
this pull request
Jul 27, 2025
…dowed (swc-project#10947) **Related issue:** - Closes swc-project#10938
lukesandberg
pushed a commit
to lukesandberg/swc
that referenced
this pull request
Jul 27, 2025
…dowed (swc-project#10947) **Related issue:** - Closes swc-project#10938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't optimize Number properties when Number is shadowed