Skip to content

fix: moveElemsAttrsToGroups should not move transform if group has filter attribute - #1933

Merged
SethFalco merged 3 commits into
svg:mainfrom
johnkenny54:issue-1752
Jan 15, 2024
Merged

fix: moveElemsAttrsToGroups should not move transform if group has filter attribute#1933
SethFalco merged 3 commits into
svg:mainfrom
johnkenny54:issue-1752

Conversation

@johnkenny54

Copy link
Copy Markdown
Contributor

Closes #1752

As far as I can tell, this change has no effect on regression.js - same number of mismatches, identical total file compression.

@SethFalco SethFalco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR, and sorry for the delay. I was pretty busy last week.

The fix makes sense to me, but I'd like if we could simplify the test case before merging.

Comment thread test/plugins/moveElemsAttrsToGroup.08.svg.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

moveElemsAttrsToGroup breaks icon when transform and filter are present

2 participants