fix: add types for SVG bindable attributes #16525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following props are bindable in SVG elements, but the type definition only includes them for HTML elements.
This means that currently, svelte-check throws an error for this line:
Here's the error:
I moved the definitions for these attributes from
HTMLAttributes
to the parentDOMAttributes
object so they can be used by both HTML and SVG elements.Weirdly, direct binding (without get/set functions) like below does not get flagged as an error. I'm not sure why.
That might indicate there is a deeper issue here in the typechecking process. But in the meantime this updated type definition seems to solve the issue. :)
Tests and linting
pnpm test
and lint the project withpnpm lint