Skip to content

chore: Correct transport docs #13893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2025
Merged

chore: Correct transport docs #13893

merged 2 commits into from
Jun 17, 2025

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

Fixes #13847

The docs say you have to return false which is only partially correct; any falsey value will opt out of encoding

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f390aef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github marked this pull request as ready for review June 16, 2025 17:33
@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-kit-13893-svelte.vercel.app/

Conduitry
Conduitry reviewed Jun 16, 2025
View reviewed changes
@eltigerchino eltigerchino added the documentation Improvements or additions to documentation label Jun 17, 2025
@eltigerchino eltigerchino merged commit 293392b into main Jun 17, 2025
31 of 32 checks passed
@eltigerchino eltigerchino deleted the elliott/13847 branch June 17, 2025 04:37
sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Jun 21, 2025
@sidharthv96
Merge branch 'main' into sidv/styleText
f16e43d 
* main:
  bye bye red lines (sveltejs#13911)
  docs: mention support for vite 7 as well
  docs: mention that rolldown is experimental
  docs: expand changelog entry
  Version Packages (sveltejs#13908)
  feat: support Rolldown (sveltejs#13747)
  chore: Correct transport docs (sveltejs#13893)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conduitry Conduitry Conduitry left review comments

@eltigerchino eltigerchino eltigerchino approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transport hooks did not encode falsy value
3 participants
@elliott-with-the-longest-name-on-github @Conduitry @eltigerchino