Skip to content

fix: deprecate cloudflare platform.context in favor for platform.ctx #13856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2025

Conversation

vnphanquang
Copy link
Contributor

@vnphanquang vnphanquang commented Jun 4, 2025

fixes #13851

I don't mind platform.context but it seems this is creating some inconsistency for people using create-cloudflare today. For the record, as far as I can remember, getPlatformProxy uses ctx, and in Cloudflare docs they use ctx as well.

Here are the places where platform.ctx typing is defined in create-cloudflare templates for Svelte:


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jun 4, 2025

🦋 Changeset detected

Latest commit: 66503e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry I left this one for such a long time. I added a simple test to make sure we always have ctx

@eltigerchino eltigerchino merged commit fb88ff7 into sveltejs:main Jun 30, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: adapter-cloudflare: create-cloudflare app.d.ts (platform.ctx) mismatches emulation (platform.context)
2 participants