chore: get rid of class-replacement hack #13664
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used a grotesque hack that would ensure the
HttpError
etc classes would be the same between what Vite imports via its transformation toolchain and what you get from a regular node import.Turns out we don't need that anymore - since #9242 SvelteKit is guaranteed to always be loaded through the Vite toolchain.
This investigation was triggered by vitest-dev/vitest#7783 - removing this might alleviate the pressure on Vitest, though we still do some
vite.ssrLoadModule
suspicously close to theconfigureServer
hook, so we'll see.