Skip to content

fix: preload data on tap after code was preloaded on hover #13530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2025

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Mar 3, 2025

fixes #13466 (for real this time)

#13486 previously fixed the preload on tap not working by ensuring we do not skip checking the link until a preload has triggered. However, there's also the case where we have both preload link options: preload code on hover and preload data on tap.

This PR ensures that we still preload data on tap even after a successful preload on hover if the preload on hover was only preloading code.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Mar 3, 2025

🦋 Changeset detected

Latest commit: 0633140

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

if (!a || a === current_a) return;

// we don't want to preload data again if the user has already hovered/tapped
const interacted = a === current_a && priority >= current_priority;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? I could've hovered like 10 minutes ago if I left for another tab, or to eat a sandwich or something, then came back and hovered again -- not sure we'd want to serve stale data in that case

Copy link
Member Author

@eltigerchino eltigerchino Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has already been the behaviour since we cache the load data on hover. Additionally, @dummdidumm added the a === current_a skip condition as part of the server-side route resolution PR and it does help to skip more of the preload code while hovering over the same link (previously, you could move your mouse across the same link and this function would get called every 20ms).

Maybe we should add a timer to expire the load data cache?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can investigate that separately - for now this looks good to fix the bug

@dummdidumm dummdidumm merged commit 6e97d5f into main Mar 4, 2025
15 checks passed
@dummdidumm dummdidumm deleted the fix-double-link-options branch March 4, 2025 11:57
@github-actions github-actions bot mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SvelteKit 2.17.0: data-sveltekit-preload-data=“tap” no longer works
3 participants