-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
docs: fix endpoint filename, types #13483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you! There's one more file misname just below your edits - could you check that aswell? |
export type RequestHandler = Kit.RequestHandler<RouteParams, RouteId>; | ||
export type RequestEvent = Kit.RequestEvent<RouteParams, RouteId>; | ||
export type RequestHandler = Kit.RequestHandler<RouteParams>; | ||
export type RequestEvent = Kit.RequestEvent<RouteParams>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed RouteId
so that it matches the PageLoad
documentation:
export type PageLoad = Kit.Load<RouteParams, PageServerData, PageParentData, OutputData, RouteId>; // actual: too long
export type PageLoad = Kit.Load<RouteParams>; // existing: kept as-is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Current documentation mixes
+server.js
and+page.server.js
descriptions.I have unified it to the former. Maybe latter is more desirable?
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits