Skip to content

feat: implements .jsonc support to adapter-cloudflare-workers #13467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 21, 2025
Merged

feat: implements .jsonc support to adapter-cloudflare-workers #13467

merged 15 commits into from
Feb 21, 2025

Conversation

duducpp
Copy link
Contributor

@duducpp duducpp commented Feb 14, 2025

resolves #13465

This PR implementes the same jsonc-parser used in cloudflare wrangler


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: d758e05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare-workers Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

@duducpp duducpp changed the title Feat/jsonc parse feat: jsonc parse Feb 14, 2025
@duducpp duducpp changed the title feat: jsonc parse feat: jsonc-parse Feb 14, 2025
@duducpp duducpp closed this Feb 14, 2025
@duducpp duducpp reopened this Feb 14, 2025
@duducpp duducpp changed the title feat: jsonc-parse feat: implements .jsonc support to adapter-cloudflare-workers Feb 14, 2025
@benmccann
Copy link
Member

This would need to be in adapter-cloudflare as well as we normally try to keep the two in sync

removes jsonc-parser dependency
@duducpp
Copy link
Contributor Author

duducpp commented Feb 14, 2025

This would need to be in adapter-cloudflare as well as we normally try to keep the two in sync

I also tried updating it in adapter-cloudflare but I couldnt find any references to the wrangler config file on it.

Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've updated the docs as well (and fixed some links). It seems like Cloudflare is also pushing for wrangler.jsonc files over wrangler.toml files in their docs

@eltigerchino eltigerchino merged commit 908a948 into sveltejs:main Feb 21, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Feb 21, 2025
@duducpp duducpp deleted the feat/jsonc-parse branch February 25, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapter-cloudflare-workers not parsing default .jsonc
3 participants