Skip to content

feat: vitest use client and server side testing #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thirty-ducks-buy.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'sv': patch
---

feat: `vitest` use client and server side testing for `kit`
6 changes: 5 additions & 1 deletion packages/addons/_tests/vitest/test.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { execSync } from 'node:child_process';
import { expect } from '@playwright/test';
import { setupTest } from '../_setup/suite.ts';
import vitest from '../../vitest-addon/index.ts';
Expand All @@ -7,7 +8,10 @@ const { test, variants, prepareServer } = setupTest({ vitest });
test.concurrent.for(variants)('core - %s', async (variant, { page, ...ctx }) => {
const cwd = await ctx.run(variant, { vitest: {} });

const { close } = await prepareServer({ cwd, page });
const { close } = await prepareServer({ cwd, page }, () => {
execSync('npm run test', { cwd, stdio: 'pipe' });
});

// kill server process when we're done
ctx.onTestFinished(async () => await close());

Expand Down
150 changes: 100 additions & 50 deletions packages/addons/vitest-addon/index.ts
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
import { dedent, defineAddon, log } from '@sveltejs/cli-core';
import { common, exports, imports, object } from '@sveltejs/cli-core/js';
import { array, common, exports, functions, imports, object } from '@sveltejs/cli-core/js';
import { parseJson, parseScript } from '@sveltejs/cli-core/parsers';

export default defineAddon({
id: 'vitest',
shortDescription: 'unit testing',
homepage: 'https://vitest.dev',
options: {},
run: ({ sv, typescript }) => {
run: ({ sv, typescript, kit }) => {
const ext = typescript ? 'ts' : 'js';

sv.devDependency('vitest', '^3.0.0');
sv.devDependency('@testing-library/svelte', '^5.2.4');
sv.devDependency('@testing-library/jest-dom', '^6.6.3');
sv.devDependency('jsdom', '^25.0.1');

sv.file('package.json', (content) => {
const { data, generateCode } = parseJson(content);
Expand Down Expand Up @@ -39,62 +42,109 @@ export default defineAddon({
`;
});

if (kit) {
sv.file(`${kit.routesDirectory}/page.svelte.test.${ext}`, (content) => {
if (content) return content;

return dedent`
import { describe, test, expect } from 'vitest';
import '@testing-library/jest-dom/vitest';
import { render, screen } from '@testing-library/svelte';
import Page from './+page.svelte';

describe('/+page.svelte', () => {
test('should render h1', () => {
render(Page);
expect(screen.getByRole('heading', { level: 1 })).toBeInTheDocument();
});
});
`;
});
} else {
sv.file(`src/App.svelte.test.${ext}`, (content) => {
if (content) return content;

return dedent`
import { describe, test, expect } from 'vitest';
import '@testing-library/jest-dom/vitest';
import { render, screen } from '@testing-library/svelte';
import App from './App.svelte';

describe('App.svelte', () => {
test('should render h1', () => {
render(App);
expect(screen.getByRole('heading', { level: 1 })).toBeInTheDocument();
});
});
`;
});
}

sv.file(`vitest-setup-client.${ext}`, (content) => {
if (content) return content;

return dedent`
import '@testing-library/jest-dom/vitest';
import { vi } from 'vitest';

// required for svelte5 + jsdom as jsdom does not support matchMedia
Object.defineProperty(window, 'matchMedia', {
writable: true,
enumerable: true,
value: vi.fn().mockImplementation(query => ({
matches: false,
media: query,
onchange: null,
addEventListener: vi.fn(),
removeEventListener: vi.fn(),
dispatchEvent: vi.fn(),
})),
})

// add more mocks here if you need them
`;
});

sv.file(`vite.config.${ext}`, (content) => {
const { ast, generateCode } = parseScript(content);

// find `defineConfig` import declaration for "vite"
const importDecls = ast.body.filter((n) => n.type === 'ImportDeclaration');
const defineConfigImportDecl = importDecls.find(
(importDecl) =>
(importDecl.source.value === 'vite' || importDecl.source.value === 'vitest/config') &&
importDecl.importKind === 'value' &&
importDecl.specifiers?.some(
(specifier) =>
specifier.type === 'ImportSpecifier' && specifier.imported.name === 'defineConfig'
)
);

// we'll need to replace the "vite" import for a "vitest/config" import.
// if `defineConfig` is the only specifier in that "vite" import, remove the entire import declaration
if (defineConfigImportDecl?.specifiers?.length === 1) {
const idxToRemove = ast.body.indexOf(defineConfigImportDecl);
ast.body.splice(idxToRemove, 1);
} else {
// otherwise, just remove the `defineConfig` specifier
const idxToRemove = defineConfigImportDecl?.specifiers?.findIndex(
(s) => s.type === 'ImportSpecifier' && s.imported.name === 'defineConfig'
);
if (idxToRemove) defineConfigImportDecl?.specifiers?.splice(idxToRemove, 1);
}

const config = common.expressionFromString('defineConfig({})');
const defaultExport = exports.defaultExport(ast, config);
imports.addNamed(ast, '@testing-library/svelte/vite', { svelteTesting: 'svelteTesting' });

const test = object.create({
include: common.expressionFromString("['src/**/*.{test,spec}.{js,ts}']")
const clientObjectExpression = object.create({
extends: common.createLiteral(`./vite.config.${ext}`),
plugins: common.expressionFromString('[svelteTesting()]'),
test: object.create({
name: common.createLiteral('client'),
environment: common.createLiteral('jsdom'),
clearMocks: common.expressionFromString('true'),
include: common.expressionFromString("['src/**/*.svelte.{test,spec}.{js,ts}']"),
exclude: common.expressionFromString("['src/lib/server/**']"),
setupFiles: common.expressionFromString(`['./vitest-setup-client.${ext}']`)
})
});
const serverObjectExpression = object.create({
extends: common.createLiteral(`./vite.config.${ext}`),
test: object.create({
name: common.createLiteral('server'),
environment: common.createLiteral('node'),
include: common.expressionFromString("['src/**/*.{test,spec}.{js,ts}']"),
exclude: common.expressionFromString("['src/**/*.svelte.{test,spec}.{js,ts}']")
})
});

// uses the `defineConfig` helper
if (
defaultExport.value.type === 'CallExpression' &&
defaultExport.value.arguments[0]?.type === 'ObjectExpression'
) {
// if the previous `defineConfig` was aliased, reuse the alias for the "vitest/config" import
const importSpecifier = defineConfigImportDecl?.specifiers?.find(
(sp) => sp.type === 'ImportSpecifier' && sp.imported.name === 'defineConfig'
);
const defineConfigAlias = (importSpecifier?.local?.name ?? 'defineConfig') as string;
imports.addNamed(ast, 'vitest/config', { defineConfig: defineConfigAlias });

object.properties(defaultExport.value.arguments[0], { test });
} else if (defaultExport.value.type === 'ObjectExpression') {
// if the config is just an object expression, just add the property
object.properties(defaultExport.value, { test });
} else {
// unexpected config shape
log.warn('Unexpected vite config for vitest add-on. Could not update.');
const defineConfigFallback = functions.call('defineConfig', []);
const { value: defineWorkspaceCall } = exports.defaultExport(ast, defineConfigFallback);
if (defineWorkspaceCall.type !== 'CallExpression') {
log.warn('Unexpected vite config. Could not update.');
}

const vitestConfig = functions.argumentByIndex(defineWorkspaceCall, 0, object.createEmpty());
const testObject = object.property(vitestConfig, 'test', object.createEmpty());

const workspaceArray = object.property(testObject, 'workspace', array.createEmpty());
array.push(workspaceArray, clientObjectExpression);
array.push(workspaceArray, serverObjectExpression);

return generateCode();
});
}
Expand Down