fix: resolve golangci-lint modernize and nolintlint errors #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use strings.Cut instead of strings.Index in parseVarOpts - Use strings.CutPrefix instead of TrimPrefix in parseVarEnvs - Add omitzero to nested struct fields in config.go - Use slices.Contains instead of manual loop in config_test.go - Remove unused //nolint:gosec directives in comment.go - Use maps.Copy instead of manual loop in template.go - Use strings.Builder instead of string concatenation in loop 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Use strings.Cut instead of strings.Index in parseVarOpts - Use strings.CutPrefix instead of TrimPrefix in parseVarEnvs - Disable omitzero check in modernize linter (jsonschema library needs omitempty) - Use slices.Contains instead of manual loop in config_test.go - Remove unused //nolint:gosec directives in comment.go - Use maps.Copy instead of manual loop in template.go - Use strings.Builder instead of string concatenation in loop 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
suzuki-shunsuke
force-pushed
the
fix/lint-modernize
branch
from
8fe4804 to
1c76b38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
The omitzero lint check is disabled because invopop/jsonschema doesn't support
omitzeroyet. See invopop/jsonschema#161🤖 Generated with Claude Code