GHES auth token env-var names mismatch

[philpennock]

pinact version

3.6.0

$ pinact -v
pinact version 3.6.0

Environment

• OS (Windows, Linux, macOS, etc): Linux
• CPU Architecture (amd64, arm64, etc): amd64

Overview

How to reproduce

• Read docs for GHES support
• See the list of environment variables at "GitHub Access Token for GHES"
• Cross-check against the gh official client tool

Expected Behaviour

The official env-vars should all be supported, in the same precedence order.

Actual Behaviour

GH_ENTERPRISE_TOKEN is missing

Important Factoids

The only two official env-var names are, in priority order:

1. GH_ENTERPRISE_TOKEN
2. GITHUB_ENTERPRISE_TOKEN

Since pinact only supports the second precedence name, anyone using the correct first precedence name won't interoperate cleanly with pinact.

References

• https://cli.github.com/manual/gh_help_environment

[suzuki-shunsuke]

pinact doesn’t support the GH_ENTERPRISE_TOKEN environment variable.
GH_TOKEN and GH_ENTERPRISE_TOKEN are environment variables used by the GitHub CLI.
In general, many tools support GITHUB_TOKEN but do not support GH_TOKEN, so it’s not unusual that pinact doesn’t support GH_TOKEN or GH_ENTERPRISE_TOKEN.
If pinact were to support all environment variables used by the GitHub CLI, it would become difficult to use different access tokens for pinact and the GitHub CLI.