feat(realtime): add presence-enabled flag to join push #736
+96
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add presenceEnabled property to RealtimeJoinConfig - Update CallbackManager to handle presence-enabled joins - Modify RealtimeChannelV2 to support presence-enabled configuration - Add tests for presence-enabled functionality - Update .gitignore for new test artifacts This change allows developers to explicitly enable/disable presence functionality when joining realtime channels, providing better control over presence behavior in realtime subscriptions.
Pull Request Test Coverage Report for Build 15971610786Details
💛 - Coveralls |
- Add comprehensive test that verifies presence.enabled is set to true when presence callback exists - Test uses FakeWebSocket to simulate real subscription flow - Verifies that presence enabled flag is correctly set in phx_join payload - Ensures proper cleanup of subscriptions and connections This test validates the core functionality where presence enabled is automatically set based on presence callback existence.
…bscribed channel When a presence callback is added to an already subscribed channel, the channel now automatically resubscribes to ensure the presence functionality works correctly. This fixes an issue where presence callbacks added after subscription would not receive presence updates. - Add resubscription logic in onPresenceChange method - Log debug message when resubscribing - Maintain existing callback registration behavior
dshukertjr
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the presence enabled flag in the realtime join push. When a presence callback exists on a channel, the presence enabled flag is automatically set to true during the subscription process.
Changes
RealtimeChannelV2.subscribe()to setconfig.presence.enabled = truewhen presence callbacks existcallbackManager.callbacks.contains(where: { $0.isPresence })to detect presence callbackstestPresenceEnabledDuringSubscribe()that verifies the presence enabled flag is correctly set during subscriptionTest Coverage
The new test
testPresenceEnabledDuringSubscribe()inTests/RealtimeTests/RealtimeChannelTests.swift:FakeWebSocketto simulate real WebSocket communicationpresence.enabledflag is set totruein thephx_joinpayload when presence callbacks existTechnical Details
The implementation automatically enables presence when:
onPresenceChange()This ensures that presence functionality is only enabled when actually needed, optimizing server-side processing and network traffic.
Testing
All existing tests pass, and the new test validates the core functionality:
swift test --filter RealtimeChannelTestsRelated Issues
Closes #CLIBS-219