chore: bump edition for all crates to 2024 #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imor
commented
Jul 3, 2025
| @@ -277,7 +277,7 @@ pub async fn read_all_pipelines( | |||
| /// Helper function to check if an sqlx error is a duplicate pipeline constraint violation | |||
| pub fn is_duplicate_pipeline_error(err: &sqlx::Error) -> bool { | |||
| match err { | |||
| sqlx::Error::Database(ref db_err) => { | |||
| sqlx::Error::Database(db_err) => { | |||
There was a problem hiding this comment.
Calling out a few places where upgrading the edition caused compiler errors to make it easy to review. The rest of the noise is mostly due to clippy warning fixes or cargo fmt changes.
Comment on lines
+105
to
+107
| unsafe { | ||
| std::env::set_var("RUST_LOG", "info"); | ||
| } |
There was a problem hiding this comment.
Needed due to edition update.
Comment on lines
+105
to
+107
| unsafe { | ||
| std::env::set_var("RUST_LOG", "info"); | ||
| } |
There was a problem hiding this comment.
Needed due to edition update.
| std::env::set_var("RUST_LOG", "info"); | ||
| unsafe { | ||
| std::env::set_var("RUST_LOG", "info"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Needed due to edition update.
Comment on lines
+19
to
+23
| let state_store = init_state_store( | ||
| replicator_config.pipeline.id, | ||
| replicator_config.pipeline.pg_connection.clone(), | ||
| ) | ||
| .await?; |
There was a problem hiding this comment.
Needed due to edition update.
| pub async fn migrate_state_store(connection_config: PgConnectionConfig) -> Result<(), sqlx::Error> { | ||
| pub async fn migrate_state_store( | ||
| connection_config: &PgConnectionConfig, | ||
| ) -> Result<(), sqlx::Error> { | ||
| let options: PgConnectOptions = connection_config.with_db(); |
There was a problem hiding this comment.
Needed due to edition update.
iambriccardo
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
cargo fmt