Skip to content

feat: add x-sb-error-code header, show error code in logs #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hf merged 1 commit into from
Sep 24, 2024
Merged

feat: add x-sb-error-code header, show error code in logs #1765

hf merged 1 commit into from
Sep 24, 2024

Conversation

@hf
Copy link
Contributor

@hf hf commented Sep 4, 2024

Adds the x-sb-error-code header to non-2XX responses if the error has an error code determined. This is picked up by the request logger which includes it in the request completed log.

Furthermore, the same header can be picked up by the API gateway (Supabase world) without having to parse the response to include the error code in request logs too.

@hf hf requested a review from a team as a code owner September 4, 2024 20:09
J0
J0 reviewed Sep 5, 2024
View reviewed changes
J0
J0 reviewed Sep 5, 2024
View reviewed changes
@J0
Copy link
Contributor

J0 commented Sep 5, 2024

Approving first even though build is failing, the build errors are from gosec upgrade which I'll fix shortly in a separate PR

cstockton
cstockton approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@cstockton cstockton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hf hf force-pushed the hf/x-sb-error-code branch from e923339 to ae92b3e Compare September 24, 2024 07:10
@hf hf merged commit ed91c59 into master Sep 24, 2024
@hf hf deleted the hf/x-sb-error-code branch September 24, 2024 07:16
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
Merged
@coveralls
Copy link

coveralls commented Sep 24, 2024

Pull Request Test Coverage Report for Build 11008809499

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 57.743%
Totals Coverage Status
Change from base Build 11008788490: 0.03%
Covered Lines: 9214
Relevant Lines: 15957
💛 - Coveralls

hf pushed a commit that referenced this pull request Sep 24, 2024
@github-actions
chore(master): release 2.161.0 (#1760)
5b03fda 
🤖 I have created a release *beep* *boop*
---


##
[2.161.0](v2.160.0...v2.161.0)
(2024-09-24)


### Features

* add `x-sb-error-code` header, show error code in logs
([#1765](#1765))
([ed91c59](ed91c59))
* add webauthn configuration variables
([#1773](#1773))
([77d5897](77d5897))
* config reloading
([#1771](#1771))
([6ee0091](6ee0091))


### Bug Fixes

* add additional information around errors for missing content type
header ([#1576](#1576))
([c2b2f96](c2b2f96))
* add token to hook payload for non-secure email change
([#1763](#1763))
([7e472ad](7e472ad))
* update aal requirements to update user
([#1766](#1766))
([25d9874](25d9874))
* update mfa admin methods
([#1774](#1774))
([567ea7e](567ea7e))
* user sanitization should clean up email change info too
([#1759](#1759))
([9d419b4](9d419b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cemalkilic pushed a commit that referenced this pull request Aug 7, 2025
@hf @cemalkilic
feat: add x-sb-error-code header, show error code in logs (#1765)
eefe5bf 
Adds the `x-sb-error-code` header to non-2XX responses if the error has
an error code determined. This is picked up by the request logger which
includes it in the request completed log.

Furthermore, the same header can be picked up by the API gateway
(Supabase world) without having to parse the response to include the
error code in request logs too.
cemalkilic pushed a commit that referenced this pull request Aug 7, 2025
@github-actions @cemalkilic
chore(master): release 2.161.0 (#1760)
366e918 
🤖 I have created a release *beep* *boop*
---


##
[2.161.0](v2.160.0...v2.161.0)
(2024-09-24)


### Features

* add `x-sb-error-code` header, show error code in logs
([#1765](#1765))
([ed91c59](ed91c59))
* add webauthn configuration variables
([#1773](#1773))
([77d5897](77d5897))
* config reloading
([#1771](#1771))
([6ee0091](6ee0091))


### Bug Fixes

* add additional information around errors for missing content type
header ([#1576](#1576))
([c2b2f96](c2b2f96))
* add token to hook payload for non-secure email change
([#1763](#1763))
([7e472ad](7e472ad))
* update aal requirements to update user
([#1766](#1766))
([25d9874](25d9874))
* update mfa admin methods
([#1774](#1774))
([567ea7e](567ea7e))
* user sanitization should clean up email change info too
([#1759](#1759))
([9d419b4](9d419b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
xeladotbe pushed a commit to xeladotbe/supabase-auth that referenced this pull request Sep 27, 2025
@hf @xeladotbe
feat: add x-sb-error-code header, show error code in logs (supabase…
d4f6efd 
…#1765)

Adds the `x-sb-error-code` header to non-2XX responses if the error has
an error code determined. This is picked up by the request logger which
includes it in the request completed log.

Furthermore, the same header can be picked up by the API gateway
(Supabase world) without having to parse the response to include the
error code in request logs too.
xeladotbe pushed a commit to xeladotbe/supabase-auth that referenced this pull request Sep 27, 2025
@github-actions @xeladotbe
chore(master): release 2.161.0 (supabase#1760)
431c9a8 
🤖 I have created a release *beep* *boop*
---


##
[2.161.0](supabase/auth@v2.160.0...v2.161.0)
(2024-09-24)


### Features

* add `x-sb-error-code` header, show error code in logs
([supabase#1765](supabase#1765))
([ed91c59](supabase@ed91c59))
* add webauthn configuration variables
([supabase#1773](supabase#1773))
([77d5897](supabase@77d5897))
* config reloading
([supabase#1771](supabase#1771))
([6ee0091](supabase@6ee0091))


### Bug Fixes

* add additional information around errors for missing content type
header ([supabase#1576](supabase#1576))
([c2b2f96](supabase@c2b2f96))
* add token to hook payload for non-secure email change
([supabase#1763](supabase#1763))
([7e472ad](supabase@7e472ad))
* update aal requirements to update user
([supabase#1766](supabase#1766))
([25d9874](supabase@25d9874))
* update mfa admin methods
([supabase#1774](supabase#1774))
([567ea7e](supabase@567ea7e))
* user sanitization should clean up email change info too
([supabase#1759](supabase#1759))
([9d419b4](supabase@9d419b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
issuedat pushed a commit that referenced this pull request Sep 30, 2025
@hf @issuedat
feat: add x-sb-error-code header, show error code in logs (#1765)
d793030 
Adds the `x-sb-error-code` header to non-2XX responses if the error has
an error code determined. This is picked up by the request logger which
includes it in the request completed log.

Furthermore, the same header can be picked up by the API gateway
(Supabase world) without having to parse the response to include the
error code in request logs too.
issuedat pushed a commit that referenced this pull request Sep 30, 2025
@github-actions @issuedat
chore(master): release 2.161.0 (#1760)
d592996 
🤖 I have created a release *beep* *boop*
---


##
[2.161.0](v2.160.0...v2.161.0)
(2024-09-24)


### Features

* add `x-sb-error-code` header, show error code in logs
([#1765](#1765))
([ed91c59](ed91c59))
* add webauthn configuration variables
([#1773](#1773))
([77d5897](77d5897))
* config reloading
([#1771](#1771))
([6ee0091](6ee0091))


### Bug Fixes

* add additional information around errors for missing content type
header ([#1576](#1576))
([c2b2f96](c2b2f96))
* add token to hook payload for non-secure email change
([#1763](#1763))
([7e472ad](7e472ad))
* update aal requirements to update user
([#1766](#1766))
([25d9874](25d9874))
* update mfa admin methods
([#1774](#1774))
([567ea7e](567ea7e))
* user sanitization should clean up email change info too
([#1759](#1759))
([9d419b4](9d419b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cstockton cstockton cstockton approved these changes

+1 more reviewer

@J0 J0 J0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hf @J0 @coveralls @cstockton