-
-
Notifications
You must be signed in to change notification settings - Fork 54
Add support for third party auth and add Slack OIDC provider #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should this also apply to realtime? @grdsdev @dshukertjr |
grdsdev
requested changes
Aug 12, 2024
Supabase/src/commonMain/kotlin/io/github/jan/supabase/AccessTokenProvider.kt
Outdated
Show resolved
Hide resolved
dshukertjr
reviewed
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, but yes this should work with all services including realtime! Thanks for working on this!
GoTrue/src/commonMain/kotlin/io/github/jan/supabase/gotrue/AccessToken.kt
Show resolved
Hide resolved
dshukertjr
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
No support for third party auth and missing the Slack OIDC provider.
What is the new behavior?
The provider has been added and there is a new option in the
SupabaseClientBuilder
:If this property is not null, the
Auth
plugin will not be available and this custom provider function will be used for auth.Additional context
Check supabase/supabase-js#1004.