Skip to content

Add support for third party auth and add Slack OIDC provider #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 15, 2024

Conversation

jan-tennert
Copy link
Collaborator

@jan-tennert jan-tennert commented Aug 12, 2024

What kind of change does this PR introduce?

Feature

What is the current behavior?

No support for third party auth and missing the Slack OIDC provider.

What is the new behavior?

The provider has been added and there is a new option in the SupabaseClientBuilder:

val supabase = createSupabaseClient(supabaseUrl, supabaseKey) {
    accessToken = {
          //fetch the third party token
         "my-token"
    }
}

If this property is not null, the Auth plugin will not be available and this custom provider function will be used for auth.

Additional context

Check supabase/supabase-js#1004.

@jan-tennert jan-tennert added the enhancement New feature or request label Aug 12, 2024
@jan-tennert jan-tennert self-assigned this Aug 12, 2024
@github-actions github-actions bot added the auth label Aug 12, 2024
@jan-tennert
Copy link
Collaborator Author

jan-tennert commented Aug 12, 2024

Should this also apply to realtime? @grdsdev @dshukertjr

@github-actions github-actions bot added the tests label Aug 12, 2024
@jan-tennert jan-tennert requested a review from grdsdev August 12, 2024 15:33
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, but yes this should work with all services including realtime! Thanks for working on this!

@jan-tennert jan-tennert merged commit 446d3d7 into master Aug 15, 2024
6 of 12 checks passed
@jan-tennert jan-tennert deleted the third-party-auth branch August 15, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants