Add extended unit tests for MusicBlocks.run behavior#5539
Open
badassscoder wants to merge 3 commits intosugarlabs:masterfrom
Open
Add extended unit tests for MusicBlocks.run behavior#5539badassscoder wants to merge 3 commits intosugarlabs:masterfrom
badassscoder wants to merge 3 commits intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@walterbender this test is ready could you please review it |
Member
|
please address the conflict |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@walterbender can you please review it |
Member
|
another conflict :( |
Contributor
Author
|
@walterbender sorry for the bad commits i think there is something which i missed because of this is occuring i will make all the changes properly and then call out for review. |
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@walterbender could you please check the commit again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds extended unit test coverage for the
MusicBlocks.runmethod, ensuring correct execution flow, listener cleanup, and safe handling of edge cases.Changes
MusicBlocks.runTest Coverage
firstNoteTimeScope
Verification