upgrade(ngx-store): Upgrade to latest ngrx-store version #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IbenTesara
added
upgrade
WHeirstrate
reviewed
Jun 2, 2025
Comment on lines
+28
to
+30
| "@ngrx/entity": "^19.2.1", | ||
| "@ngrx/store": "^19.2.1", | ||
| "@ngrx/effects": "^19.2.1", |
There was a problem hiding this comment.
Why is this version not fixed unlike the one in the root package.json? Won't it always take 19.2.1 due to the version in the deps having a higher priority than the peerDeps? I'll keep looking for some sources...
There was a problem hiding this comment.
Pretty sure we've been doing it like this for a while now in the other packages, simply to prevent people from getting stuck the way you are currently.
It's a bit of a trade-off and not a perfect solution, but the one that causes the least friction for the users of the package.
There was a problem hiding this comment.
Fair enough, I'll approve!
WHeirstrate
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to latest store version
Requirements