-
Notifications
You must be signed in to change notification settings - Fork 292
feat: add support for Billie #1956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@wooj-stripe @porter-stripe @nschris-stripe would love some 👀 on this, and some help on next steps 🙏 |
@mats-stripe @cttsai-stripe @davidme-stripe would love some 👀 on this, and some help on next steps 🙏 |
@LinusU thank you for this pull request, could you please get this rebased with master and passing CI? Once it is I am happy to review this pull request and accept this contribution. |
@porter-stripe I've rebased on latest It seems to me like the test failure was unrelated to my change, as it was in the "sofort" payment provider. It seems like this payment provider have been discontinued by Stripe as of March 31, 2025. Could this be why the tests are failing? |
@porter-stripe rebased again to fix conflict in changelog |
ping @porter-stripe I think that you need to click "approve" in order to run the E2E tests every time that I push new code, could you please run them now? 🙏 |
Hmm, I don't see how this error is related to my changes 🧐 @porter-stripe do you have any idea on what could be happening? |
@LinusU Sorry about that - our CI workflows were unexpectedly impacted by these changes: https://github.blog/changelog/2025-07-11-upcoming-changes-to-macos-hosted-runners-macos-latest-migration-and-xcode-support-policy-updates/ We'll try to have it resolved as soon as possible, and keep you posted. |
@mats-stripe thank you! @porter-stripe I've fixed the TypeScript test failure, it was indeed something I missed during development, still not sure why my local test run didn't catch it though 🤔 |
@mats-stripe I think that I've found a fix for the CI, submitted as PR here: #2066 |
I've rebased on top of latest |
Hi @LinusU looks like the Android code needs some formatting! "Run './gradlew :spotlessApply' to fix these violations." |
@porter-stripe thanks, sorry for missing it, fixed code pushed 🙏 |
@porter-stripe seems like all checks are passing 🙌 Let me know if you need anything else! |
# [0.51.0](v0.50.0...v0.51.0) (2025-08-20) ### Bug Fixes * ensure handleNextActionForSetup passes returnURL parameter on Android ([stripe#2021](https://github.com/appchoose/stripe-react-native/issues/2021)) ([1593381](1593381)), closes [stripe#1960](https://github.com/appchoose/stripe-react-native/issues/1960) * Make currencyCode optional for setup mode on Android to match iOS behavior ([stripe#2018](https://github.com/appchoose/stripe-react-native/issues/2018)) ([b6bacff](b6bacff)) ### Features * add support for Billie ([stripe#1956](https://github.com/appchoose/stripe-react-native/issues/1956)) ([a644bcb](a644bcb)) * **minor:** release version ([ffca8b0](ffca8b0))
Summary
I've added support for the Billie payment method.
Motivation
I need to use Billie in our React Native app.
Testing
Documentation
Select one:
Please let me know if there is anything more I can do! E.g. I'm not sure where to add documentation, I searched the repo for "klarna" and made sure to implement Billie in all the same places, but there was no docs...
I also added the code after Bancontact, since that sorts lexicographically, but it seemed like the current code isn't sorted by anything special. Happy to update if you want it in any other way...
Fixes #1953