Skip to content

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented May 29, 2025

Summary

I've added support for the Billie payment method.

Motivation

I need to use Billie in our React Native app.

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.
  • I'm not sure where to add documentation

Please let me know if there is anything more I can do! E.g. I'm not sure where to add documentation, I searched the repo for "klarna" and made sure to implement Billie in all the same places, but there was no docs...

I also added the code after Bancontact, since that sorts lexicographically, but it seemed like the current code isn't sorted by anything special. Happy to update if you want it in any other way...

Fixes #1953

@LinusU LinusU requested review from charliecruzan-stripe and a team as code owners May 29, 2025 16:07
@LinusU LinusU mentioned this pull request May 29, 2025
@LinusU
Copy link
Contributor Author

LinusU commented Jul 7, 2025

@wooj-stripe @porter-stripe @nschris-stripe would love some 👀 on this, and some help on next steps 🙏

@LinusU
Copy link
Contributor Author

LinusU commented Aug 2, 2025

@mats-stripe @cttsai-stripe @davidme-stripe would love some 👀 on this, and some help on next steps 🙏

@porter-stripe
Copy link
Collaborator

@LinusU thank you for this pull request, could you please get this rebased with master and passing CI? Once it is I am happy to review this pull request and accept this contribution.

@LinusU
Copy link
Contributor Author

LinusU commented Aug 12, 2025

@porter-stripe I've rebased on latest master, could you please run the e2e test again?

It seems to me like the test failure was unrelated to my change, as it was in the "sofort" payment provider. It seems like this payment provider have been discontinued by Stripe as of March 31, 2025. Could this be why the tests are failing?

@LinusU
Copy link
Contributor Author

LinusU commented Aug 13, 2025

@porter-stripe rebased again to fix conflict in changelog

@LinusU
Copy link
Contributor Author

LinusU commented Aug 15, 2025

ping @porter-stripe I think that you need to click "approve" in order to run the E2E tests every time that I push new code, could you please run them now? 🙏

@LinusU
Copy link
Contributor Author

LinusU commented Aug 15, 2025

error No simulator available with name "iPhone 16 (18.2)".

Hmm, I don't see how this error is related to my changes 🧐

@porter-stripe do you have any idea on what could be happening?

@LinusU
Copy link
Contributor Author

LinusU commented Aug 15, 2025

Looking into the typescript error now:

Screenshot 2025-08-15 at 16 12 28

Interestingly, I do not get it locally:

Screenshot 2025-08-15 at 16 12 46

@mats-stripe
Copy link
Contributor

@LinusU Sorry about that - our CI workflows were unexpectedly impacted by these changes: https://github.blog/changelog/2025-07-11-upcoming-changes-to-macos-hosted-runners-macos-latest-migration-and-xcode-support-policy-updates/

We'll try to have it resolved as soon as possible, and keep you posted.

@LinusU
Copy link
Contributor Author

LinusU commented Aug 15, 2025

@mats-stripe thank you!

@porter-stripe I've fixed the TypeScript test failure, it was indeed something I missed during development, still not sure why my local test run didn't catch it though 🤔

@LinusU
Copy link
Contributor Author

LinusU commented Aug 15, 2025

@mats-stripe I think that I've found a fix for the CI, submitted as PR here: #2066

@mats-stripe
Copy link
Contributor

@LinusU I believe we'll have to wait on this to merge first: #2064

@LinusU
Copy link
Contributor Author

LinusU commented Aug 15, 2025

I've rebased on top of latest master (with #2064 merged) now 🚀

@porter-stripe
Copy link
Collaborator

Hi @LinusU looks like the Android code needs some formatting!

"Run './gradlew :spotlessApply' to fix these violations."

@LinusU
Copy link
Contributor Author

LinusU commented Aug 15, 2025

@porter-stripe thanks, sorry for missing it, fixed code pushed 🙏

@LinusU
Copy link
Contributor Author

LinusU commented Aug 15, 2025

@porter-stripe seems like all checks are passing 🙌

Let me know if you need anything else!

@porter-stripe porter-stripe merged commit a644bcb into stripe:master Aug 15, 2025
10 checks passed
@LinusU LinusU deleted the lu-billie branch August 15, 2025 18:29
Appchoose-GitHub-Bot pushed a commit to appchoose/stripe-react-native that referenced this pull request Aug 20, 2025
# [0.51.0](v0.50.0...v0.51.0) (2025-08-20)

### Bug Fixes

* ensure handleNextActionForSetup passes returnURL parameter on Android ([stripe#2021](https://github.com/appchoose/stripe-react-native/issues/2021)) ([1593381](1593381)), closes [stripe#1960](https://github.com/appchoose/stripe-react-native/issues/1960)
* Make currencyCode optional for setup mode on Android to match iOS behavior ([stripe#2018](https://github.com/appchoose/stripe-react-native/issues/2018)) ([b6bacff](b6bacff))

### Features

* add support for Billie ([stripe#1956](https://github.com/appchoose/stripe-react-native/issues/1956)) ([a644bcb](a644bcb))
* **minor:** release version ([ffca8b0](ffca8b0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Billie support
3 participants