Skip to content

Conversation

Kikobeats
Copy link
Contributor

I didn't find any place where it's referenced that expires_at is in seconds.

I didn't find any place where it's referenced that expires_at is in seconds.
@Kikobeats Kikobeats requested a review from a team as a code owner August 24, 2025 09:12
@Kikobeats Kikobeats requested review from xavdid-stripe and removed request for a team August 24, 2025 09:12
Copy link

cla-assistant bot commented Aug 24, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Aug 24, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Aug 24, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@xavdid-stripe xavdid-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! per the docs, .expires_at is a ISO string, so you're correct that the * 1000 doesn't make sense here.

@xavdid-stripe xavdid-stripe enabled auto-merge (squash) August 25, 2025 17:24
@xavdid-stripe xavdid-stripe merged commit d21cdd1 into stripe:master Aug 25, 2025
9 checks passed
@Kikobeats Kikobeats deleted the patch-1 branch August 25, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants