Update merge script rule to run on every PR #2375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenye-stripe
requested review from
prathmesh-stripe and
jar-stripe
and removed request for
a team and
prathmesh-stripe
|
This is weird; I actually changed the rule in sdk-codegen/templates/rules.yml.template to do this and also to enforce squashed commits for other PRs; i thought I had rolled that out to all the repos but maybe not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We want to make the merge script rule that checks that a merge script PR uses
mergeinstead ofsquashrequired. However, in branches where this doesn't apply it runs forever.What?
Run
gen_templates.shfrom codegen to update rules.yml Will follow with all other repos if this is sucessful!See Also
https://jira.corp.stripe.com/browse/RUN_DEVSDK-1798