Migrate other Stripe infrastructure to TS #1563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anniel-stripe
force-pushed
the
anniel-migrate-remaining-infrastructure
branch
2 times, most recently
from
28d35cf to
84d3ec4
Compare
anniel-stripe
commented
Sep 26, 2022
anniel-stripe
commented
Sep 26, 2022
anniel-stripe
commented
Sep 26, 2022
anniel-stripe
commented
Sep 26, 2022
anniel-stripe
force-pushed
the
anniel-migrate-remaining-infrastructure
branch
from
84d3ec4 to
12af083
Compare
anniel-stripe
force-pushed
the
anniel-migrate-remaining-infrastructure
branch
from
59823d4 to
d4f0791
Compare
Contributor
kamil-stripe
left a comment
kamil-stripe
left a comment
There was a problem hiding this comment.
PTAL :) I'm going to finish the review later.
anniel-stripe
force-pushed
the
anniel-migrate-remaining-infrastructure
branch
from
5947000 to
651024f
Compare
Contributor
kamil-stripe
left a comment
kamil-stripe
left a comment
There was a problem hiding this comment.
Few more comments. LGTM otherwise.
Co-authored-by: Kamil Pajdzik <[email protected]>
Co-authored-by: Kamil Pajdzik <[email protected]>
Co-authored-by: Kamil Pajdzik <[email protected]>
Co-authored-by: Kamil Pajdzik <[email protected]>
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
…nfrastructure Migrate other Stripe infrastructure to TS
gurus00
pushed a commit
to gurus00/stripe-node
that referenced
this pull request
Feb 11, 2025
…nfrastructure Migrate other Stripe infrastructure to TS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
r? @kamil-stripe
Migrating remaining Stripe infrastructure files to TypeScript in a "lazy" manner. This includes the following files:
See my comments on the .ts files for explanations of why I made a few changes.