-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: Xml Comments - Update 4 #2170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Release.yml added for PR categorisation
…aced with BackgroundComponent
Contributor
Author
|
With the latest commit, this reduces the Stride Docs warnings to 79. |
Contributor
Author
|
Hello, can this be merged? |
Jklawreszuk
approved these changes
Apr 3, 2024
Collaborator
Jklawreszuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks legit to me 👌😃
Contributor
Author
|
Thanks for checking this for me @Jklawreszuk. Please, can this be merged, so we can improve our docs? |
Collaborator
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This PR is fixing numerous XML comments issues, around 60.
Description
crefreferencescrefreferences for unknown, none existing referencesNote that some references are not working because we have the same namespaces in different assemblies and then some references are not working unfortunatelly, such
crefwas removed.Once merged, these updates will be automatically applied to Stride API in the next Stride Docs release.
Related Issue
#1681
Motivation and Context
This xml comments are rendered in our Stride Docs and ideally they should work.
Types of changes
Checklist