implemented preselect for resurvey of bike repair station

[paulklie]

I tried implementing preselecting elements on resurvey of selection quests, now that the migration to compose is done for these (see #6398). This was easier than expected.

I have completed bike repair stations for now. If this solution is accepted I would also implement this for the remaining quests.

[westnordost]

Well, for opening hours, the question is also adapted:

Is this ... still correct? The user can then just answer "yes".

If the stuff is just pre-selected without comment, users might rather think this is a bug or something. Also, to immediately make the (OK) button available is not fine, in my opinion. The user didn't give an answer, yet.

[paulklie]

How about now?
I added an additional string, and a yes/no confirmation.

I also noticed that I was mistaken: this quest form is not used with any other quests that have resurvey functionality. However I still made sure we can reuse this functionality if we ever decide to add resurveying to, for example, AddSport or AddBoatRental.

[westnordost]

Yes, that is how it should be done. However, I am not quite convinced that it is worth the effort to

• add an extra string for every such re-survey-enabled quest
• add parsing to determine whether (and which) items should be pre-selected - at two locations, to boot

For what? The user still needs to check whether all that is pre-selected is still available (including scrolling down to see if any are selected further below, if applicable), the time saved of not having to click the things that are still available seems negligible.

[matkoniecz]

For what?

if user is lazy/has worse day then risk of damage to OSM data is lower

also (based on bicycle parking count preview, I kept that old buggy version for own use)..
Sometimes you think you noted/counted things, it mismatches prefilled data and it makes you look at things again - and then it turns out that you are wrong

does not happen very often to me, but far more often than I expected, and I like to think I am more careful than average mapper, especially newbie mapper

[westnordost]

Your example is from bicycle parking count, though. This is about the image select.

And it works the other way around, too. E.g. recycling containers: You see paper and glass containers. Pre-selected seems to be paper and glass, but when you (would) scroll down, you see that also clothes is selected. This one is just an example off the top of my mind, my point is that a mistake could be introduced or a previous mistake not be corrected just as well.

[matkoniecz]

I expect that similar may apply, though that is guessing

and I probably treat "not fixing data" as lesser problem than "breaking valid data"

also, if say 0.3% of edits is bad than breaking valid data in 0.3% of all resurveys is much worse than not fixing bad data in 0.3% of resurveys where data should be changed (as data needs to be changed only in some cases)

[paulklie]

add an extra string for every such re-survey-enabled quest

We might be able to avoid this by asking "Is this still correct?" and adding the original question in a seperate row. That way we only need to translate the "Is this still correct?" to all languages.

[westnordost]

Hmm, interesting idea. So that title-logic would be implemented in the *Form class, and in case it is a re-survey quest, the two questions would be appended separated by a \n I presume? This also solves the issue that parsing to determine whether (and which) items should be pre-selected had to be done at two locations, right?

[westnordost]

(or with an additional element in the layout that makes the question look visually different, e.g. slightly greyed out.)

Is this still correct?
for "What can be recycled here?"

[ paper ] [ glass ] [ plastic ]
[ shoes ] [ clothes ] [ compost ]
...
Uh... | No | Yes

[paulklie]

(or with an additional element in the layout that makes the question look visually different, e.g. slightly greyed out.)

I like this idea, would also allow removing a lot of resuvying strings.

Maybe could add a overridable function, something like IsResurvey() : boolean, with a default implementation that always returns false? And quests with resurvey capabilities can override it with their logic.

Maybe in future this could also be used to display a different icon for re-survey quests. For example, sometimes I am more likely to answer resurvey opening hours, since these require less time than adding the hours from scratch.

[westnordost]

true, this could be possible, but I don't see the sense in showing a different icon for resurvey