-
-
Notifications
You must be signed in to change notification settings - Fork 395
Aerial bothways quest #6583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Aerial bothways quest #6583
Conversation
Added and filled the backlog for first sprint
…op of the document Added a new entry for telework on 18/09/2024.
V1 without SVG pictures
paulklie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work so far!
...rc/androidMain/kotlin/de/westnordost/streetcomplete/quests/aerialBothWay/AddAerialBothWay.kt
Outdated
Show resolved
Hide resolved
...rc/androidMain/kotlin/de/westnordost/streetcomplete/quests/aerialBothWay/AddAerialBothWay.kt
Show resolved
Hide resolved
...droidMain/kotlin/de/westnordost/streetcomplete/quests/aerialway/AddAerialwayBicycleAccess.kt
Show resolved
Hide resolved
...rc/androidMain/kotlin/de/westnordost/streetcomplete/quests/aerialBothWay/AddAerialBothWay.kt
Outdated
Show resolved
Hide resolved
app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/QuestsModule.kt
Show resolved
Hide resolved
|
What worries me is that https://wiki.openstreetmap.org/wiki/Key:oneway does not mention aerialways and https://wiki.openstreetmap.org/wiki/Key:aerialway does not mention oneway key and say https://wiki.openstreetmap.org/wiki/Tag:aerialway=drag%20lift mentions only that |
|
is it a common practice to record such EDIT: https://overpass-turbo.eu/s/2ed9 - looks in some use, I will edit wiki a bit EDIT: https://wiki.openstreetmap.org/w/index.php?title=Key:oneway&diff=prev&oldid=2911167 and https://wiki.openstreetmap.org/w/index.php?title=Tag:aerialway%3Dgondola&diff=prev&oldid=2911168 made based on what I see tagged in OSM. Note that someone may protest and we should double check that this quest is not pushing brand-new or dubious or pointless tagging. |
...rc/androidMain/kotlin/de/westnordost/streetcomplete/quests/aerialBothWay/AddAerialBothWay.kt
Outdated
Show resolved
Hide resolved
Of the 28811 aerialways currently mapped (disregarding stations and pylons) 3522 have It is also a default field in iD for many aerial ways: https://github.com/openstreetmap/id-tagging-schema/blob/12f05151433f2007eaa6382d7962d005dd1acbd4/data/presets/aerialway/chair_lift.json#L8 |
3677ae7 to
724db79
Compare
|
It would probably also make sence to apply the same visibility improvement as #6590 here. |
|
@NariaReynhard are you still working on this? Otherwise I would take over to finish this |
|
I have finished the implementation, just need an icon now. |
|
I'm sorry I wasn't available for almost two weeks, and I don't really have time allocated to work on that until next week. I would've keep taking care of it at this moment but I appreciate that you took the time to handle it yourself. Sorry for the inconvinence and thank you. |
Any ideas? I would suggest reusing the gondula icon from the aerialway bicycle quest, and adding the "oneway" icon. |
Slipped out of my mind but I finally cleaned this branch to be able to PR it properly