-
-
Notifications
You must be signed in to change notification settings - Fork 395
Tower access quest #6581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tower access quest #6581
Conversation
…ar, it's just a temporary one to test the quest.
Removed the string for tower access question.
paulklie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Only a few small things
app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/tower_access/AddTowerAccess.kt
Show resolved
Hide resolved
app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/tower_access/AddTowerAccess.kt
Outdated
Show resolved
Hide resolved
westnordost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, regarding the answers: Why not allow answering "customers only" like for playgrounds and parking? For example, there may be observation towers within an amusement park, zoo, water park etc.. These observation towers are certainly not private, but also only available to those that are customers of that park.
Hmm, there are only 60 towers currently tagged this way: https://overpass-turbo.eu/s/2eDw We would also need to find some phrasing that makes it clear that a normal observation tower, which everyone may enter after paying, does not count. Maybe: "Who may enter?" "Customers of a larger place, such as a amusement park, or museum"? |
|
Just use the same wording as in the playground or parking fee quest? Alternatively, add a hint along the lines of ... "Regardless of whether entry is free or paid." |
|
Also, by the way, I find the icon a bit lazy. There is no need to make this monochrome. On the other hand, I haven't found a good (idea/template for an) icon looking in image search. One might just use the icon in |
|
I'll implement my suggestion. |
paulklie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #6502
Who may access this tower ?