Skip to content

Conversation

@ElPoraz
Copy link
Contributor

@ElPoraz ElPoraz commented Oct 20, 2025

Fixes #6502
Who may access this tower ?

@paulklie paulklie added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Oct 20, 2025
Copy link
Collaborator

@paulklie paulklie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Only a few small things

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, regarding the answers: Why not allow answering "customers only" like for playgrounds and parking? For example, there may be observation towers within an amusement park, zoo, water park etc.. These observation towers are certainly not private, but also only available to those that are customers of that park.

@paulklie
Copy link
Collaborator

Hmm, regarding the answers: Why not allow answering "customers only" like for playgrounds and parking? For example, there may be observation towers within an amusement park, zoo, water park etc.. These observation towers are certainly not private, but also only available to those that are customers of that park.

Hmm, there are only 60 towers currently tagged this way: https://overpass-turbo.eu/s/2eDw

We would also need to find some phrasing that makes it clear that a normal observation tower, which everyone may enter after paying, does not count. Maybe: "Who may enter?" "Customers of a larger place, such as a amusement park, or museum"?

@westnordost
Copy link
Member

Just use the same wording as in the playground or parking fee quest? Alternatively, add a hint along the lines of ... "Regardless of whether entry is free or paid."

@westnordost
Copy link
Member

Also, by the way, I find the icon a bit lazy. There is no need to make this monochrome. On the other hand, I haven't found a good (idea/template for an) icon looking in image search.

One might just use the icon in res/graphics/building/tower.svg, though.

@westnordost
Copy link
Member

I'll implement my suggestion.

@westnordost westnordost self-assigned this Nov 4, 2025
Copy link
Collaborator

@paulklie paulklie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quest: Who may access this tower?

4 participants