-
-
Notifications
You must be signed in to change notification settings - Fork 395
Motorcycle parking fee quest #6532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motorcycle parking fee quest #6532
Conversation
Added and filled the backlog for first sprint
…op of the document Added a new entry for telework on 18/09/2024.
paulklie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
...droidMain/kotlin/de/westnordost/streetcomplete/quests/parking_fee/AddMotorcycleParkingFee.kt
Show resolved
Hide resolved
app/src/commonMain/kotlin/de/westnordost/streetcomplete/ApplicationConstants.kt
Outdated
Show resolved
Hide resolved
|
Good job with the icon btw! Maybe the coin could be moved to the left a bit so the "motorcycle" icon is a bit clearer? |
|
Also: please include the quest icon in a .svg format in https://github.com/streetcomplete/StreetComplete/tree/master/res/graphics/quest |
|
I think @westnordost might be best to judge this, but I feel like the former is clearer. |
Sure, i wait for @westnordost opinion then i'll add it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you supply the quest icon also in SVG in /res/graphics/quest/motorcycle_parking_fee.svg ?
...droidMain/kotlin/de/westnordost/streetcomplete/quests/parking_fee/AddMotorcycleParkingFee.kt
Outdated
Show resolved
Hide resolved
...droidMain/kotlin/de/westnordost/streetcomplete/quests/parking_fee/AddMotorcycleParkingFee.kt
Outdated
Show resolved
Hide resolved
|
I find your first icon better because the motorcycle is visible better |
Yes, it's done. |
paulklie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
|
@ElPoraz can you add your icon to https://github.com/streetcomplete/StreetComplete/blob/master/res/graphics/authors.txt? Maybe refer to the other icons you used as a base. |
|
This is not necessary. It's too small of a thing to claim copyright over, IMO. (But I don't mind if you do 🤷) |


Adding the following quests suggested in #6457:
Do you have to pay to park your motorcycle here?