Skip to content

Conversation

@paulklie
Copy link
Collaborator

fixes #6461

@paulklie paulklie marked this pull request as ready for review August 22, 2025 21:49
Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd slightly prefer to have a function createVacantAnswer which does the if check, just for consistency-sake. (Or alternatively, use the takeIf also for the other one)

@westnordost
Copy link
Member

Also, a place can be shop=vacant but also e.g. disused:shop=* (, disused:amenity=*) etc.
How is this handled? Should it be handled?

@paulklie
Copy link
Collaborator Author

I'd slightly prefer to have a function createVacantAnswer which does the if check, just for consistency-sake. (Or alternatively, use the takeIf also for the other one)

good point, done

@paulklie
Copy link
Collaborator Author

Also, a place can be shop=vacant but also e.g. disused:shop=* (, disused:amenity=*) etc. How is this handled? Should it be handled?

The button does not appear in these cases eather, since the place is still correctly identified as vacant

@westnordost
Copy link
Member

Thank you!

@westnordost westnordost merged commit f5c9c3f into streetcomplete:master Aug 24, 2025
@peternewman
Copy link
Collaborator

That's a bit of a shame as I often use this to tidy up an erroneously left name (e.g. a bank that's not just vacant still having it's brand name showing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Its vacant... " on vacant place

3 participants