Crash in Places overlay

[riQQ]

Describe how to reproduce it here:

Thread: mainApp version: 62.0
Device: google bluejay, Android 16
Locale: de-DE

Stack trace:

kotlin.UninitializedPropertyAccessException: lateinit property localizedNames has not been initialized
at de.westnordost.streetcomplete.overlays.places.PlacesOverlayForm.hasChanges(SourceFile:249)
at de.westnordost.streetcomplete.overlays.AbstractOverlayForm.checkIsFormComplete(SourceFile:353)
at de.westnordost.streetcomplete.overlays.AbstractOverlayForm.onStart(SourceFile:239)
at androidx.fragment.app.Fragment.performStart(SourceFile:3192)
at androidx.fragment.app.FragmentStateManager.start(SourceFile:648)
at androidx.fragment.app.FragmentStateManager.moveToExpectedState(SourceFile:304)
at androidx.fragment.app.FragmentStore.moveToExpectedState(SourceFile:114)
at androidx.fragment.app.FragmentManager.moveToState(SourceFile:1685)
at androidx.fragment.app.FragmentManager.dispatchStateChange(SourceFile:3319)
at androidx.fragment.app.FragmentManager.dispatchStart(SourceFile:3244)
at androidx.fragment.app.FragmentController.dispatchStart(SourceFile:274)
at androidx.fragment.app.FragmentActivity.onStart(SourceFile:358)
at androidx.appcompat.app.AppCompatActivity.onStart(SourceFile:238)
at de.westnordost.streetcomplete.screens.main.MainActivity.onStart(SourceFile:287)
at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1699)
at android.app.Activity.performStart(Activity.java:9287)
at android.app.ActivityThread.handleStartActivity(ActivityThread.java:4344)
at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:214)
at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:194)
at android.app.servertransaction.TransactionExecutor.executeLifecycleItem(TransactionExecutor.java:166)
at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:101)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:80)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2830)
at android.os.Handler.dispatchMessage(Handler.java:110)
at android.os.Looper.dispatchMessage(Looper.java:315)
at android.os.Looper.loopOnce(Looper.java:251)
at android.os.Looper.loop(Looper.java:349)
at android.app.ActivityThread.main(ActivityThread.java:9041)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:593)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:929)

Log:
2025-12-14T17:07:26.965: I [Preloader] Loaded country boundaries in 0.0s
2025-12-14T17:07:27.196: I [Preloader] Loaded features dictionary in 0.2s
2025-12-14T17:07:27.197: I [Preloader] Preloading data took 0.2s 

How to Reproduce
Don't really know. The app was in the background and when I opened it again, it showed me the crash dialog.

Expected Behavior

Don't crash

Versions affected

StreetComplete 62.0 / Android 16

[westnordost]

hm. Does this happen often?

[riQQ]

First time I've seen this happen. But haven't been using StreetComplete much lately.

[westnordost]

Well I kind of hoped this would not/never happen. It is a race condition.

in onCreateView, the compose-based UI is started. That's where this value is initialized. However, it looks like this happens asynchronously.

in onStart, the value is accessed. If it is not initialized by then, it will crash.

The issue is, that I used this lateinit var pattern in a lot of quests that I converted to compose. Eventually it will not be an issue anymore (when I moved it all to compose), but it is at the moment.