Implement onNeighborListUpdated event #3076

ptesavol · 2025-04-21T20:31:14Z

Implement the neighborListUpdated event to be listened to by trackerless network users to detect changes in the neighbor list, the bufferedAmounts and upload and download rates of the neighbors to enable backpressure

Limitations:

only reports changes to bufferedAmount of BrowserWebRTC connections
Reports full NodeList contents to the onNeighborListUpdated event listeners, which might reveal too much information. Maybe in the future should implement a separate data interface that only contains the necessary data (upload and download rates etc.)?

linear · 2025-04-21T20:31:16Z

NET-1450 Report buffereddAmount of WebRTC datachannels to the users of trackerless network

… neighbors that respond too slow

packages/dht/src/connection/webrtc/BrowserWebrtcConnection.ts

packages/trackerless-network/src/logic/NodeList.ts

packages/trackerless-network/src/logic/neighbor-discovery/NeighborUpdateManager.ts

packages/trackerless-network/src/NetworkNode.ts

packages/trackerless-network/src/logic/neighbor-discovery/NeighborUpdateManager.ts

packages/trackerless-network/src/logic/NodeList.ts

packages/dht/src/connection/webrtc/BrowserWebrtcConnection.ts

juslesan · 2025-05-02T12:57:33Z

Should fix the merge conflicts with the versioning in package.json files

…tachannels-to-the-users-of-trackerless-network

packages/trackerless-network/src/content-delivery-layer/NodeList.ts

juslesan · 2025-05-14T07:41:24Z

packages/trackerless-network/src/discovery-layer/DiscoveryLayerNode.ts

@@ -17,6 +16,7 @@ export interface DiscoveryLayerNode {
    off<T extends keyof DiscoveryLayerNodeEvents>(eventName: T, listener: () => void): void
    once<T extends keyof DiscoveryLayerNodeEvents>(eventName: T, listener: (peerDescriptor: PeerDescriptor) => void): void
    once<T extends keyof DiscoveryLayerNodeEvents>(eventName: T, listener: () => void): void
+


remove unnecessary added line

juslesan · 2025-05-14T07:41:46Z

...s/trackerless-network/src/content-delivery-layer/neighbor-discovery/NeighborUpdateManager.ts

@@ -53,10 +53,12 @@ export class NeighborUpdateManager {
            const res = await this.createRemote(neighbor.getPeerDescriptor()).updateNeighbors(this.options.streamPartId, neighborDescriptors)
            const nodeId = toNodeId(neighbor.getPeerDescriptor())
            this.options.neighbors.get(nodeId)!.setRtt(Date.now() - startTime)
+


Remove unnecessary adde lines in this file

juslesan · 2025-05-14T07:45:11Z

packages/dht/src/connection/webrtc/BrowserWebrtcConnection.ts

+                this.currentBufferedAmount = bufferedAmountRemainder
+                // Update bufferedAmount in statistics but keep the upload rate the same
+                this.statistics.bufferedAmount = this.currentBufferedAmount
+                this.emit('statisticsUpdated', this.statistics)


Does this event end up being called quite often? Could there be some performance related if the bufferedAmount changes on each send

The buffered amount should stay at 0 in normal operation, and be non-zero only if you are sending too fast. Maybe we should test this out with streamrtv by making a rc release of this branch?

Okay, I suppose it would make sense to do an internal release of these changes

…tachannels-to-the-users-of-trackerless-network

implement onNeighborListChanged event

096fc62

ptesavol requested a review from juslesan April 21, 2025 20:31

github-actions bot added network Related to Network Package dht Related to DHT package labels Apr 21, 2025

ptesavol added 2 commits April 22, 2025 08:20

eslint

56de86b

refactor to a more straightforward implementation

e4bded7

ptesavol changed the title ~~Implement onNeighborListChanged event~~ Implement onNeighborListUpdated event Apr 22, 2025

ptesavol added 4 commits April 22, 2025 12:50

add user-level api for the neighborListUpdated event

f848537

release: v103.0.0-rc.4

e24664f

release: v103.0.0-rc.4

361dc46

release: v103.0.0-rc.5

38017ec

github-actions bot added test-utils Related to Test Utils Package cli-tools Related to CLI Tools Package utils proto-rpc sdk node labels Apr 22, 2025

ptesavol added 10 commits April 22, 2025 14:59

disable BrowserWebRTCClient additional buffering and disable removing…

03c5272

… neighbors that respond too slow

release: v103.0.0-rc.6

5f1b4bc

release: v103.0.0-rc.7

b12be76

release: v103.0.0-rc.8

c65488a

buffredAmout change event should now propagate to the user level

1552d48

release: v103.0.0-rc.9

00219e5

emit statistics object instead of the mere bufferedAmount

022e300

add calculating uploadrate from peerConnection getStats()

eda0e08

release: v103.0.0-rc.10

96768cd

eslint

1aa6409

ptesavol commented Apr 29, 2025

View reviewed changes

packages/dht/src/connection/webrtc/BrowserWebrtcConnection.ts Outdated Show resolved Hide resolved

ptesavol commented Apr 29, 2025

View reviewed changes

packages/trackerless-network/src/logic/NodeList.ts Outdated Show resolved Hide resolved

ptesavol commented Apr 29, 2025

View reviewed changes

packages/trackerless-network/src/logic/neighbor-discovery/NeighborUpdateManager.ts Outdated Show resolved Hide resolved

juslesan reviewed Apr 29, 2025

View reviewed changes

packages/dht/src/connection/webrtc/BrowserWebrtcConnection.ts Outdated Show resolved Hide resolved

juslesan reviewed Apr 29, 2025

View reviewed changes

packages/dht/src/connection/webrtc/BrowserWebrtcConnection.ts Outdated Show resolved Hide resolved

ptesavol and others added 3 commits April 30, 2025 13:52

re-enable removing of neighbors who take too long to respond

c24d69f

add any casting instead of useless parameters

011296b

review changes

769ba54

Merge branch 'main' into NET-1450-report-buffereddAmount-of-webrtc-da…

ff16a4d

…tachannels-to-the-users-of-trackerless-network

github-actions bot removed test-utils Related to Test Utils Package cli-tools Related to CLI Tools Package utils proto-rpc sdk node labels May 2, 2025

ptesavol added 2 commits May 13, 2025 13:32

add download rate metering

5ce3f24

merged with main

293e3fe

juslesan reviewed May 13, 2025

View reviewed changes

packages/trackerless-network/src/content-delivery-layer/NodeList.ts Outdated Show resolved Hide resolved

fix potential memory leak when removing event listener

19d1bc1

juslesan requested changes May 14, 2025

View reviewed changes

juslesan added 2 commits May 16, 2025 11:11

Merge branch 'main' into NET-1450-report-buffereddAmount-of-webrtc-da…

2d52b1e

…tachannels-to-the-users-of-trackerless-network

release: v103.0.0-rc.17

636d79c

github-actions bot added test-utils Related to Test Utils Package cli-tools Related to CLI Tools Package utils proto-rpc sdk node labels May 16, 2025

github-actions bot added the Stale label Jul 16, 2025

github-actions bot closed this Jul 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement onNeighborListUpdated event #3076

Implement onNeighborListUpdated event #3076

Uh oh!

ptesavol commented Apr 21, 2025 •

edited

Loading

Uh oh!

linear bot commented Apr 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juslesan commented May 2, 2025

Uh oh!

Uh oh!

juslesan May 14, 2025

Uh oh!

juslesan May 14, 2025

Uh oh!

juslesan May 14, 2025

Uh oh!

ptesavol May 16, 2025

Uh oh!

juslesan May 16, 2025

Uh oh!

Uh oh!

Implement onNeighborListUpdated event #3076

Implement onNeighborListUpdated event #3076

Uh oh!

Conversation

ptesavol commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linear bot commented Apr 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juslesan commented May 2, 2025

Uh oh!

Uh oh!

juslesan May 14, 2025

Choose a reason for hiding this comment

Uh oh!

juslesan May 14, 2025

Choose a reason for hiding this comment

Uh oh!

juslesan May 14, 2025

Choose a reason for hiding this comment

Uh oh!

ptesavol May 16, 2025

Choose a reason for hiding this comment

Uh oh!

juslesan May 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ptesavol commented Apr 21, 2025 •

edited

Loading