-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Core: Exclude open from pre-bundling to make local xdg-open reachable #33325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit a71d9f4
☁️ Nx Cloud last updated this comment at |
📝 WalkthroughWalkthroughThe "open" package was moved from devDependencies to dependencies in code/core/package.json, making it a production dependency rather than a development-only dependency. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (2)**/*.{js,jsx,json,html,ts,tsx,mjs}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
code/**/*.{js,jsx,json,html,ts,tsx,mjs}📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
🧠 Learnings (10)📓 Common learnings📚 Learning: 2025-09-17T07:31:04.432ZApplied to files:
📚 Learning: 2025-09-29T13:20:23.346ZApplied to files:
📚 Learning: 2025-11-24T17:49:59.279ZApplied to files:
📚 Learning: 2025-11-28T14:50:24.889ZApplied to files:
📚 Learning: 2025-11-24T17:49:59.279ZApplied to files:
📚 Learning: 2025-11-24T17:49:59.279ZApplied to files:
📚 Learning: 2025-11-24T17:49:59.279ZApplied to files:
📚 Learning: 2025-11-24T17:49:31.838ZApplied to files:
📚 Learning: 2025-11-24T17:49:59.279ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
Comment |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 39 | 49 | 🚨 +10 🚨 |
| Self size | 20.54 MB | 20.52 MB | 🎉 -16 KB 🎉 |
| Dependency size | 16.41 MB | 16.50 MB | 🚨 +98 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 173 | 183 | 🚨 +10 🚨 |
| Self size | 774 KB | 774 KB | 🚨 +84 B 🚨 |
| Dependency size | 67.61 MB | 67.70 MB | 🚨 +83 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 166 | 176 | 🚨 +10 🚨 |
| Self size | 30 KB | 30 KB | 0 B |
| Dependency size | 66.19 MB | 66.27 MB | 🚨 +83 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
create-storybook
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 40 | 50 | 🚨 +10 🚨 |
| Self size | 1000 KB | 1000 KB | 0 B |
| Dependency size | 36.94 MB | 37.03 MB | 🚨 +83 KB 🚨 |
| Bundle Size Analyzer | node | node |
Core: Exclude open from pre-bundling to make local xdg-open reachable (cherry picked from commit 6d70bfe)
Fixes one part of #32949
What I did
Excluded
openfrom pre-bundling so that its local version ofxdg-openis reachable and usable. This prevents crashes on container systems wherexdg-openis not always installed.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Not sure how to test this without messing with the local OS filesystem. LMK if you want new unit tests though.
Manual testing
nextand notice a crashDocumentation
ø
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.