Skip to content

Update more details-Observability service (post GA or when in progress features are complete) #7974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.14_stage
Choose a base branch
from

Conversation

PoornimaSingour
Copy link

@PoornimaSingour PoornimaSingour commented Jun 18, 2025

Update more details related to StorageClass in Enabling the Observability service Section.

BUG : https://issues.redhat.com/browse/ACM-21655

Added:

Note: By default if you do not define the storageConfig.storageClass field in the MultiClusterObservability custom resource, platforms default StorageClass will be populated in the storageConfig section of MultiClusterObservability. For example for AWS default storageClass will be gp2. You can verify default storageClass using below command:

$ oc get storageClass
NAME                PROVISIONER       RECLAIMPOLICY   VOLUMEBINDINGMODE      ALLOWVOLUMEEXPANSION   AGE
gp2-csi             ebs.csi.aws.com   Delete          WaitForFirstConsumer   true                   151m
gp3-csi (default)   ebs.csi.aws.com   Delete          WaitForFirstConsumer   true                   151m

Also $ was missing in front of all the command so added that as well.

…lity service Section

Update more details related to StorageClass in Enabling the Observability service  Section
Copy link

openshift-ci bot commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PoornimaSingour

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PoornimaSingour
Copy link
Author

PoornimaSingour commented Jun 18, 2025

/label peer-review-in-needed

Copy link

openshift-ci bot commented Jun 18, 2025

@PoornimaSingour: The label(s) /label peer-review-in-progress cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label peer-review-in-progress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@PoornimaSingour
Copy link
Author

/label peer-review-in-needed

Copy link

openshift-ci bot commented Jun 18, 2025

@PoornimaSingour: The label(s) /label peer-review-in-needed cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label peer-review-in-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@swopebe
Copy link
Contributor

swopebe commented Jun 18, 2025

@PoornimaSingour thanks for the PR, however, can you point us to the JIRA issue for the doc team that reflects this change?
We cannot start peer review or tech review without tacking the change/understanding the change via a doc issue.

If no issue was opened, you can open one from this procedure:

https://docs.google.com/document/d/1YTqpZRH54Bnn4WJ2nZmjaCoiRtqmrc2w6DdQxe_yLZ8/edit?tab=t.0#heading=h.nmome2yn9lvr

@swopebe swopebe changed the title Update more details related to StorageClass in Enabling the Observability service Section Update more details-Observability service (not ready for review, issue requested-bcs) Jun 18, 2025
@PoornimaSingour
Copy link
Author

HI @swopebe Yes here is the JIRA https://issues.redhat.com/browse/ACM-21655. DO let me know if any details are needed.

@swopebe swopebe changed the title Update more details-Observability service (not ready for review, issue requested-bcs) Update more details-Observability service Jun 20, 2025
@swopebe
Copy link
Contributor

swopebe commented Jun 20, 2025

Thanks, we will pick this up as soon as we can. We generally don't add $ to the commands in ACM doc, we never really have (this content was moved from IBM and we stuck to those practices.) I know OCP adds it.

@swopebe swopebe changed the title Update more details-Observability service Update more details-Observability service (post GA or when in progress features are complete) Jun 23, 2025
@oafischer oafischer requested a review from dockerymick June 26, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants