generic alt enums + pwm channel builders #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
force-pushed
the
alt-pwm-simple
branch
7 times, most recently
from
26c1c2b to
49e9287
Compare
burrbull
force-pushed
the
alt-pwm-simple
branch
from
0a5d5ef to
51ebf4a
Compare
burrbull
force-pushed
the
alt-pwm-simple
branch
from
51ebf4a to
102a33a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @therealprof
cc @janschiefer
I planning to change API for passing pins in PWM constructors. Now you need to specify channel number manually. See examples:
https://github.com/stm32-rs/stm32f4xx-hal/blob/alt-pwm-simple/examples/pwm-dead-time.rs
https://github.com/stm32-rs/stm32f4xx-hal/blob/alt-pwm-simple/examples/pwm.rs
Could you test, please?