Skip to content

Conversation

burrbull
Copy link
Member

Related to #505

Instead of changing API I added alternative.

So now to can choose between Tx, Rx with erased information about pins and UTx, URx which can join to restore Serial

Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

bors r+

bors bot added a commit that referenced this pull request Aug 15, 2022
514: Serial Tx, Rx containing pins r=therealprof a=burrbull

Related to #505 

Instead of changing API I added alternative.

So now to can choose between `Tx`, `Rx` with erased information about pins and `UTx`, `URx` which can join to restore `Serial`

Co-authored-by: Andrey Zgarbul <[email protected]>
@bors
Copy link
Contributor

bors bot commented Aug 15, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@burrbull
Copy link
Member Author

bors retry

@bors bors bot merged commit 1e12e92 into master Aug 15, 2022
@bors bors bot deleted the nondestructive branch August 15, 2022 11:02
@burrbull burrbull mentioned this pull request Aug 15, 2022
bors bot added a commit that referenced this pull request Aug 16, 2022
515: Deref for UTx, URx r=therealprof a=burrbull

Removes boilerplate from #514

Co-authored-by: Andrey Zgarbul <[email protected]>
bors bot added a commit that referenced this pull request Oct 18, 2022
541: fix removed Tx::Write<u8> r=therealprof a=burrbull

Fix #528 .
Restore implementation accidentally removed in #514

Co-authored-by: Andrey Zgarbul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants