Fix defmt support #465
Merged
Fix defmt support #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks |
|
Could you also move |
|
Changelog updated and I added a commit with the hd44780-driver moved to dev-dependencies. |
burrbull
approved these changes
Mar 15, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now on relase 0.12 (and master) this:
fails to compile due to
defmtsupport in fugit not being enabled.This workaround fixes that, but feels like a hack.
It's described here: https://blog.turbo.fish/cargo-features/
The other option is to rename the fugit feature under a different name, but this fix could be used until then.
Let me know if you want this to be merged and I can write a Changelog entry.