Support eMMC in SDIO module #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
reviewed
Feb 24, 2022
burrbull
approved these changes
Feb 28, 2022
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 28, 2022
458: Support eMMC in SDIO module r=burrbull a=antonok-edm Followup to jkristell/sdio-host#10, which will also be required before this PR can be merged (cc `@jkristell)` This PR adds support for eMMC peripherals using the SDIO module. `Sdio` is now generic over an `SdioPeripheral`, which can either be a `SdCard` or `Emmc`. Many of the methods are generic enough to be shared between both, although some (like initialization) need to be specialized for each. Co-authored-by: Anton Lazarev <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Feb 28, 2022
458: Support eMMC in SDIO module r=burrbull a=antonok-edm Followup to jkristell/sdio-host#10, which will also be required before this PR can be merged (cc `@jkristell)` This PR adds support for eMMC peripherals using the SDIO module. `Sdio` is now generic over an `SdioPeripheral`, which can either be a `SdCard` or `Emmc`. Many of the methods are generic enough to be shared between both, although some (like initialization) need to be specialized for each. Co-authored-by: Anton Lazarev <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors merge |
richardeoin
added a commit
to richardeoin/stm32h7xx-hal
that referenced
this pull request
Mar 27, 2022
richardeoin
added a commit
to richardeoin/stm32h7xx-hal
that referenced
this pull request
Mar 27, 2022
richardeoin
added a commit
to richardeoin/stm32h7xx-hal
that referenced
this pull request
Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to jkristell/sdio-host#10, which will also be required before this PR can be merged (cc @jkristell)
This PR adds support for eMMC peripherals using the SDIO module.
Sdiois now generic over anSdioPeripheral, which can either be aSdCardorEmmc. Many of the methods are generic enough to be shared between both, although some (like initialization) need to be specialized for each.