Skip to content

WithPwm #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2022
Merged

WithPwm #425

merged 1 commit into from
Feb 1, 2022

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Jan 27, 2022 •
edited
Loading

add support WithPwm trait implemented for timers with channels.
Add Pwm struct with split method and implementation of embedded-hal::Pwm (similar to f1xx-hal)
Add channel events, make Event use bitflags (simplify interrupt handling)

@burrbull burrbull marked this pull request as ready for review January 30, 2022 03:59
therealprof
therealprof previously approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 1, 2022

Merge conflict.

@burrbull
Copy link
Member Author

burrbull commented Feb 1, 2022

rebased

therealprof
therealprof approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 1, 2022

Build succeeded:

@bors bors bot merged commit 41d8dd9 into master Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @therealprof