Skip to content

compute arr, psc #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 22, 2022
Merged

compute arr, psc #422

merged 3 commits into from
Jan 22, 2022

Conversation

burrbull
Copy link
Member

No description provided.

Disasm
Disasm reviewed Jan 19, 2022
View reviewed changes
@burrbull burrbull marked this pull request as ready for review January 21, 2022 06:27
therealprof
therealprof reviewed Jan 21, 2022
View reviewed changes
src/timer.rs Outdated
@@ -351,6 +351,15 @@ where
}
}

#[inline(always)]
pub(crate) fn compute_arr_presc(freq: u32, clock: u32) -> (u16, u32) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a const fn?

@burrbull burrbull marked this pull request as draft January 21, 2022 16:01
@burrbull burrbull marked this pull request as ready for review January 22, 2022 13:46
@burrbull
Copy link
Member Author

@therealprof Made some tests more. Works good as for me.

therealprof
therealprof approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 22, 2022

Build succeeded:

@bors bors bot merged commit 9928bb3 into master Jan 22, 2022
@burrbull burrbull deleted the arr-presc branch January 23, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

+1 more reviewer

@Disasm Disasm Disasm left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burrbull @Disasm @therealprof