Add missing CAN1 pin mapping for stm32f446 #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
previously approved these changes
Jan 18, 2022
|
Is there any other missed chips/pins? |
SheldonLemoine
force-pushed
the
AddCan1PinMappingFor446
branch
from
5937676 to
bc188c6
Compare
I went through a few more peripherals on F446 and found a missing assignment for spi3. Other than that, everything seems good for the peripherals I've checked (mostly CAN and SPI) on the F446. I've updated this PR with the additional change. |
burrbull
approved these changes
Jan 19, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference stm32f446 datasheet pages 55 and 58.