Optimized version of index_set_to_selection #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndex_set. Sort and unique an index_set if it's not guaranteed to be so
| return result; | ||
| } | ||
|
|
There was a problem hiding this comment.
Should add a comment here about what this algorithm does.
…meeting the preconditions
| \ingroup selection_algorithms | ||
|
|
||
| OLD VERSION (before September 2016) Takes a set of indices and converts them to a boundary-based Selection | ||
| */ | ||
| template <typename Selection, typename ForwardRange> |
There was a problem hiding this comment.
Just remove the old version - it is quadratic and of no use anymore.
… the iterator-based signature
| } | ||
|
|
||
| /****************************************************************************************************/ | ||
| /*! | ||
| \ingroup selection_algorithms | ||
|
|
||
| Takes a set of indices and converts them to a boundary-based Selection | ||
| Takes a boundary-based Selection and converts them to a set of indices |
There was a problem hiding this comment.
Updated the function description + added example usage.
|
Looks good to me - definitely an improvement over what we have now. @sean-parent? |
|
@sean-parent @fosterbrereton Ping. Using it in our code, works great. |
sean-parent
approved these changes
Sep 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
index_setif it's not guaranteed to be strictly increasing.index_setis known to be strictly increasing already,strictly_increasing_index_set_to_selection()function may be used to skipstd::sortandstd::uniquecalls.