-
Notifications
You must be signed in to change notification settings - Fork 429
docs(testing): document how to pass in Jest CLI arguments #1316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alicewriteswrongs are there any cases that you know of where Stencil overrides Jest configuration flags? IIRC, there is some overlap between certain options, but I'm unsure if they're worth calling out here due to functional differences
EDIT: Forgot the link https://github.com/ionic-team/stencil/blob/79dc0159d216824d623e34f814dfeb32474a1550/src/cli/config-flags.ts#L42
The Jest config is built here: https://github.com/ionic-team/stencil/blob/main/src/testing/jest/jest-29/jest-config.ts#L12 It will use both I believe that given the way the command-line arguments are marshalled before they're passed to Jest any Jest arguments that are passed should be passed through without Stencil editorializing them. Some of those Jest arguments may just also have a side-effect of setting a particular Stencil configuration value |
also strictly speaking the Our parser will set all of those on the |
@alicewriteswrongs thanks for the insights. I updated the patch to reflect what you are describing, does it make sense? Do you see anything missing we should mention? |
Based on a question we've received in stenciljs/core#5225 (reply in thread) I think it is worth to document this.